Include formGroup on character count and pass through to textarea to … #1553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…allow class to be added to character count form group
36degrees
reviewed
Sep 5, 2019
There was a problem hiding this comment.
Thanks for this @LBHELewis – great work, and thanks for writing tests and documenting the option in the YAML file!
Would you mind adding an entry to the changelog as well? Then we can get this approved and merged.
|
@36degrees Great, thank you. I've updated the changelog now. Put it as a New Feature, but I think you could also argue that it's a Fix, so let me know if you'd like me to change it. |
|
No, I think that makes sense – thanks! 🙂 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…allow class to be added to character count form group
Hopefully this should make sense. Found myself in a situation where I wanted to add a class to the formGroup but couldn't when using character count so included it in the params that get passed through to the textarea (where it was already present).